-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal end-point for ejpd request processing. #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
smatting
requested changes
May 5, 2021
Do we have to apply the change in 3b8dfeb manually? But then why did the error change? |
The host looks suspicious, I'm pretty sure |
fisx
changed the title
Internal end-point for ejpd request processing.
Internal end-point for ejpd request processing. [skip-ci]
May 5, 2021
In my (poor) defense, it was tested, but via a containing type in another package.
we have to config files in brig integration tests: one for integration tests, and one for the brig service itself. locally, we use brig.integration.yaml for both and make sure that it contains the fields for both parsers. this caused the brig-integration executable to find brig locally. further, there is an end-point for brig in the brig service config in our helm charts. this caused the brig-integration executable to look for brig under localhost in the CI, which failed. looking for the brig end-point in the integration config, not the service config, should fix things.
thanks @akshaymankar ! ef69c83 |
smatting
approved these changes
May 6, 2021
fisx
changed the title
Internal end-point for ejpd request processing. [skip-ci]
Internal end-point for ejpd request processing.
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at streamlining the internal process at wire.com described here.
We are legally required to sometimes provide user information to law enforcement. This change introduces an internal end-point to compile the minimum required information into a json blob.
Security: to access the internal end-point, you need the same access privileges that also give you direct access to the database. So the information we provide here does not get any more accessible. On the other hand, direct database access is error prone and make result in revealing information on the wrong user due to cut&paste errors. This end-point mitigates this risk to a large extent.