Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #1501

Merged
merged 10 commits into from
May 13, 2021
Merged

Cleanup #1501

merged 10 commits into from
May 13, 2021

Conversation

fisx
Copy link
Contributor

@fisx fisx commented May 12, 2021

  • some haddocks, formatting
  • re-arrange helpers
  • make API client functions in integration tests more polymorphic (needed for upcoming tests)
  • none of these changes should change behavior
  • i recomment reading commit by commit

@fisx fisx requested a review from jschaul May 12, 2021 09:02
services/galley/src/Galley/API/Error.hs Outdated Show resolved Hide resolved
services/galley/src/Galley/API/LegalHold.hs Outdated Show resolved Hide resolved
@jschaul
Copy link
Member

jschaul commented May 12, 2021

Failing test:

      GET, PUT [/i]?/teams/{tid}/legalhold - too large:

FAIL

        Exception: No code?

        CallStack (from HasCallStack):

          error, called at test/integration/API/Util.hs:404:40 in main:API.Util

          getInvitationCode, called at test/integration/API/Util.hs:337:23 in main:API.Util

          addUserToTeamWithRole', called at test/integration/API/Util.hs:320:18 in main:API.Util

          addUserToTeamWithRole, called at test/integration/API/Util.hs:313:17 in main:API.Util

          addUserToTeam, called at test/integration/API/Util.hs:109:12 in main:API.Util

          createBindingTeamWithMembers, called at test/integration/API/Teams/LegalHold.hs:536:29 in main:API.Teams.LegalHold

@fisx
Copy link
Contributor Author

fisx commented May 13, 2021

Pretty sure this is unrelated, but I've made an attempt at fixing it under the assumption it's a race condition: c331dea

@fisx
Copy link
Contributor Author

fisx commented May 13, 2021

(couldn't reproduce locally, btw)

@fisx fisx merged commit f8e6dfc into develop May 13, 2021
@fisx fisx deleted the SQSERVICES-402-cleanup branch May 13, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants