Client-supported features end-point #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisx
force-pushed
the
SQSERVICES-417-client-version
branch
2 times, most recently
from
726291a to
4e04d1e
Compare
fisx
force-pushed
the
SQSERVICES-417-client-version
branch
from
4e04d1e to
1fe3ea4
Compare
fisx
force-pushed
the
SQSERVICES-417-client-version
branch
from
1fe3ea4 to
50d08e3
Compare
jschaul
reviewed
May 17, 2021
jschaul
approved these changes
May 17, 2021
There was a problem hiding this comment.
See inline comments for things to improve; the functionality of storing client input is implemented alright.
However as I don't really see what the plan is to use this information afterwards, this is only a tentative approval of this particular storing functionality, not of a first part of a general plan. i.e. this code may get reverted entirely in the future if the plan how to make use of these features doesn't materialize.
For upcoming PRs please get reviews on the implementation ideas first before writing a lot of code.
fisx
force-pushed
the
SQSERVICES-417-client-version
branch
from
13f8632 to
b946968
Compare
This reverts commit e9376d8
(This is useful because in the next commit, we'll have to chop the module skope in half at these types with `makePrism`, and that would break things.)
fisx
force-pushed
the
SQSERVICES-417-client-version
branch
from
bd83d9f to
8a85a04
Compare
fisx
force-pushed
the
SQSERVICES-417-client-version
branch
from
b422a3d to
c4e40b8
Compare
fisx
force-pushed
the
SQSERVICES-417-client-version
branch
from
91678b8 to
3cd136c
Compare
jschaul
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/SQSERVICES-417
changelog update (and possibly a few lines of documentation) coming up.
TODO:
legalholdkeyword tolegalhold-implicit-consentfeaturetocapability