Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DerivingVia a package default. #1505

Merged
merged 3 commits into from
May 14, 2021
Merged

Make DerivingVia a package default. #1505

merged 3 commits into from
May 14, 2021

Conversation

fisx
Copy link
Contributor

@fisx fisx commented May 13, 2021

This has been bugging me for a while. I'll just add this minimal commit so we won't have to mention DerivingVia in the package heades any more in the future, but I'll leave the old ones in there for the sake of laziness.

@pcapriotti
Copy link
Contributor

Yes, good idea. It would be nice to remove the corresponding pragmas as well. This should do it:

fd -ehs --exec sed -i '/LANGUAGE DerivingVia/d'

@fisx fisx requested a review from pcapriotti May 14, 2021 07:31
@fisx
Copy link
Contributor Author

fisx commented May 14, 2021

fd looks cool, thanks for the pointer! (package fd-find in debian)

(for the record: i deliberately decided against removing it to make this as simple and swift as possible and then move back to other business. but entering one more command wasn't too bad either. :))

Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@fisx fisx merged commit dc831bc into develop May 14, 2021
@fisx fisx deleted the package-defaults branch May 14, 2021 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants