Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve naming conventions federation RPC calls #1511

Merged
merged 7 commits into from
May 19, 2021
Merged

Improve naming conventions federation RPC calls #1511

merged 7 commits into from
May 19, 2021

Conversation

pcapriotti
Copy link
Contributor

No description provided.

@pcapriotti pcapriotti marked this pull request as ready for review May 18, 2021 09:01
@pcapriotti pcapriotti requested a review from smatting May 18, 2021 09:01
@pcapriotti pcapriotti merged commit 2e5ead6 into develop May 19, 2021
@pcapriotti pcapriotti deleted the federation-rpc-naming branch May 19, 2021 06:17
@jschaul jschaul mentioned this pull request Jun 28, 2021
Merged
3 tasks
jschaul added a commit that referenced this pull request Jun 28, 2021
@jschaul
Adjust grpccurl and python client examples to recent protobuf changes
5ab023e 
Both the grpcurl and the python client were not working anymore after the changes made in #1447, #1445 and #1511
This PR adjusts these scripts under ./hack/federation to work again.
jschaul added a commit that referenced this pull request Jun 29, 2021
@jschaul
Adjust grpccurl and python client examples to recent protobuf changes (…
25cc4e9 
…#1632)

Both the grpcurl and the python client were not working anymore after the changes made in #1447, #1445 and #1511
This PR adjusts these scripts under ./hack/federation to work again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschaul jschaul jschaul left review comments

@smatting smatting smatting approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcapriotti @smatting @jschaul