Add legalhold status to user profile #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smatting
changed the title
smatting
force-pushed
the
SQSERVICES-461-lh-status
branch
2 times, most recently
from
ade8e81 to
c9ab0d4
Compare
fisx
force-pushed
the
SQSERVICES-461-lh-status
branch
2 times, most recently
from
6e8aa05 to
0bc516c
Compare
fisx
force-pushed
the
SQSERVICES-461-lh-status
branch
from
0bc516c to
0e6f202
Compare
fisx
changed the title
fisx
approved these changes
May 23, 2021
|
|
||
| instance ToSchema UserLegalHoldStatus where | ||
| declareNamedSchema = tweak . genericDeclareNamedSchema opts | ||
| schema = |
There was a problem hiding this comment.
In the future, this stuff should go into a separate PR. Especially so since this patch and the patch that you actually wanted to work on are commutative.
| @@ -1,5 +1,4 @@ | |||
| {-# LANGUAGE RecordWildCards #-} | |||
| {-# OPTIONS_GHC -Wno-orphans #-} | |||
| @@ -900,7 +901,7 @@ botGetSelfH bot = json <$> botGetSelf bot | |||
| botGetSelf :: BotId -> Handler Public.UserProfile | |||
| botGetSelf bot = do | |||
| p <- lift $ User.lookupUser NoPendingInvitations (botUserId bot) | |||
| maybe (throwStd userNotFound) (return . Public.publicProfile) p | |||
| maybe (throwStd userNotFound) (return . (`Public.publicProfile` UserLegalHoldNoConsent)) p | |||
There was a problem hiding this comment.
Actually, this is an interesting question: what should be the default for bots? (And not just the value here, also the corresp. behavior. Maybe bots also have a member record and we can just pull that here, and answer this question later?)
mdimjasevic
pushed a commit
that referenced
this pull request
May 25, 2021
* Add legalhold status to user profile * Work around bug in test utils. see https://wearezeta.atlassian.net/browse/SQSERVICES-471 Co-authored-by: Matthias Fischmann <mf@zerobuzz.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.