Release 2021-05-31 #1553
Closed
Release 2021-05-31 #1553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cargohold: Override outside mimetype to always be application/octet-stream on upload * reduce diff change by scoping variables better * minor refactoring * Add a note to swagger * wording in comments: consistency
* Move federation errors from brig to wire-api-federation * Move federation -> wai error translation to wire-api-federation * Check if remote users exist when adding to a conversation * Enable federation in galley integration tests * Add remote user to conversation: invalid domain test * Disable add remote member test for now * Mock federator in add remote users test * Test add non-existing remote user * Make federationNotConfigured error more general It used to be specific to brig, but not it is used by galley as well. * Add federator to galley's helm charts * Make failure test more plausible Test scenario where both Bob and Charlie are added to a conversation, but only Charlie exists on the remote backend. * Handle deleted remote users when adding to a conversation Also add corresponding test * galley: Update comment to addMembers Mark first point of the TODO list as DONE, but leave it there for future reference.
* Add required fields to Swagger schemas There are two parts to this: 1) SchemaDoc is now an instance of a NearSemiRing type class, to support the existence of two different schema concatenation operations. The second operation `add` is used by the Alternative instance, and the main one `(<>)` continues to be used by the Applicative one. The Swagger implementation of `add` works the same as `(<>)`, but it intersects required fields instead of concatenating them. 2) Required fields are added to the Swagger doc by the `field` combinator. Single fields are always required, whereas trivial fields obtained with say `pure` are not. Since the `Alternative` instance intersects required fields, we automatically get the correct behaviour that fields with a default value are not required, as well as fields that use the `optional` combinator from `Control.Applicative`. Unfortunately, the NearSemiRing instance for Swagger is not exactly law-abiding, but this comes down to Swagger not really being designed to support schema alternatives. In special situations, one might need to tweak the required field of the resulting schema, but the current solution should cover most cases. * Use Monoid instance for element SchemaP The Alternative instance used to work as well (and have the same implementation), but after the introduction of the NearSemiRing constraint for doc, the Monoid instance is the only one that can be used in this case.
* schema-profunctor: Simpler implementation of lax. * More documentation for schema-profunctor
* remove superfluous pragma Co-authored-by: Stefan Matting <stefan@wire.com>
* setLegalholdStatusInternal: Use same guard * canUserJoinTeam: use same guard * factor out separate check for activation hook * fix bug in guards
* Relation -> RelationHistory + TODOs * Fix: lookup connections for blocking 1:1 convs, not convs directly. Connect convs do not contain the other user, so in order to find the other user it's not good to go through that. * fix: unblock filters unneccessarily on convtype * Make tests more exhaustive. Co-authored-by: Stefan Matting <stefan@wire.com>
* Refactoring-friendly FutureWork data type. * Remove duplicate FUTUREWORK. * Remove mysterious FUTUREWORK.
* Update Rich Info docs remove any mention of the deprecated API * Update rich-info.md
|
obsolete with #1577 merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Features
Bug fixes and other updates
Documentation
Internal changes