Notify remote backends when users join #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcapriotti
force-pushed
the
pcapriotti/remote-update-conv-membership
branch
from
b36c70d to
577ade7
Compare
pcapriotti
changed the title
pcapriotti
force-pushed
the
pcapriotti/remote-update-conv-membership
branch
2 times, most recently
from
1f69b23 to
a24c00d
Compare
pcapriotti
changed the title
pcapriotti
force-pushed
the
pcapriotti/remote-update-conv-membership
branch
from
a24c00d to
2dcb90a
Compare
pcapriotti
changed the title
pcapriotti
force-pushed
the
pcapriotti/remote-update-conv-membership
branch
from
f2a8c33 to
a7cdbb7
Compare
pcapriotti
force-pushed
the
pcapriotti/remote-update-conv-membership
branch
from
a7cdbb7 to
bdf3660
Compare
pcapriotti
force-pushed
the
pcapriotti/remote-update-conv-membership
branch
from
bdf3660 to
7708b88
Compare
Before this change, only backends of new users (including local ones) were notified of a conversation update.
mdimjasevic
approved these changes
Jun 7, 2021
| $ others | ||
| . nubOrd | ||
| . map (unTagged . rmId) | ||
| $ rmm <> rothers |
There was a problem hiding this comment.
If I am getting this right, this traversing rightfully notifies remote users. Is there an equivalent for local users?
There was a problem hiding this comment.
This doesn't directly notify users, but it calls the update-conversation-memberships federation RPC, which will in turn notify users on its backend.
Notifications for local users are sent in the two statements that follow.
pcapriotti
force-pushed
the
pcapriotti/remote-update-conv-membership
branch
from
7708b88 to
8642c1e
Compare
…update-conv-membership
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a backend notify remote backends when users join a conversation.
Note: this includes commits from #1570. Rebase them away before merging.