Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptive comments to ConversationMemberUpdate #1578

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

mdimjasevic
Copy link
Contributor

No description provided.

@mdimjasevic mdimjasevic requested review from pcapriotti and jschaul June 8, 2021 10:07
Copy link
Member

@jschaul jschaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor nitpicks follow.

@mdimjasevic mdimjasevic merged commit 5edf9fe into develop Jun 8, 2021
@mdimjasevic mdimjasevic deleted the mdimjasevic/conversation-member-update-docs branch June 8, 2021 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants