Remove resource requests #1581
Merged
Remove resource requests #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschaul
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
Your assumption is correct, this is only used during tests on CI.
Possibly if too many clusters are running, something will break in a weird way when there isn't enough CPU or memory available, but we can diagnose and possibly set better resource requests following that (the current resource requests are very ad-hoc and not based on any data)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand correctly, these are only used in tests, so there should be no danger in disabling them. With those requests on, I cannot run two clusters on my machine, so I always have to apply this patch locally, which is inconvenient.