Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federation: POST /list-conversations endpoint #1591

Merged
merged 15 commits into from
Jun 28, 2021
Merged

Conversation

jschaul
Copy link
Member

@jschaul jschaul commented Jun 10, 2021

This implements a new endpoint POST /list-conversations similar to the existing GET /conversations but allows specifying parameters, such as a list of remote conversations in its request body. It will also, when called with an empty body, return a user's remote conversations.
This is part of https://wearezeta.atlassian.net/browse/SQCORE-134

todos:

  • implement local conversations behaviour
  • same test coverage than GET /conversations
  • actually make remote calls
  • mockFederator test
  • end2end test

Checklist

  • Title of this PR explains the impact of the change.
  • The description provides context as to why the change should occur and
    what the code contributes to that effect. This could also be a link to a
    JIRA ticket or a Github issue, if there is one.
  • If a component uses a new or changed internal endpoint of another
    component, this is mentioned in the CHANGELOG.md.
  • The CHANGELOG.md file in the Unreleased section has been updated to
    explain the change which will be included in the release notes.
  • If this PR creates a new endpoint, or adds a new configuration flag, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.

@jschaul jschaul changed the title [WIP] List conversations [WIP] List conversations [skip ci] Jun 10, 2021
@jschaul jschaul force-pushed the list-conversations branch 2 times, most recently from 604ef60 to 599f56e Compare June 17, 2021 20:46
@jschaul jschaul force-pushed the list-conversations branch from a776d6d to c88e034 Compare June 22, 2021 09:58
@jschaul jschaul force-pushed the list-conversations branch from c88e034 to 3ea11fa Compare June 22, 2021 10:06
@jschaul jschaul changed the title [WIP] List conversations [skip ci] [WIP] List conversations Jun 22, 2021
@jschaul jschaul changed the title [WIP] List conversations Federation: POST /list-conversations endpoint Jun 25, 2021
@jschaul jschaul marked this pull request as ready for review June 25, 2021 10:36
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Minor comments follow.

EDIT: the end2end test is failing, though. 🤔

libs/wire-api/src/Wire/API/Conversation.hs Outdated Show resolved Hide resolved
services/galley/src/Galley/API/Query.hs Outdated Show resolved Hide resolved
services/galley/test/integration/API.hs Outdated Show resolved Hide resolved
@jschaul jschaul merged commit cf87ee4 into develop Jun 28, 2021
@jschaul jschaul deleted the list-conversations branch June 28, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants