-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Federation: POST /list-conversations endpoint #1591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschaul
force-pushed
the
list-conversations
branch
2 times, most recently
from
June 17, 2021 20:46
604ef60
to
599f56e
Compare
jschaul
commented
Jun 17, 2021
jschaul
force-pushed
the
list-conversations
branch
from
June 22, 2021 09:58
a776d6d
to
c88e034
Compare
jschaul
force-pushed
the
list-conversations
branch
from
June 22, 2021 10:06
c88e034
to
3ea11fa
Compare
jschaul
changed the title
[WIP] List conversations
Federation: POST /list-conversations endpoint
Jun 25, 2021
pcapriotti
approved these changes
Jun 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Minor comments follow.
EDIT: the end2end test is failing, though. 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new endpoint
POST /list-conversations
similar to the existingGET /conversations
but allows specifying parameters, such as a list of remote conversations in its request body. It will also, when called with an empty body, return a user's remote conversations.This is part of https://wearezeta.atlassian.net/browse/SQCORE-134
todos:
Checklist
what the code contributes to that effect. This could also be a link to a
JIRA ticket or a Github issue, if there is one.
component, this is mentioned in the CHANGELOG.md.
explain the change which will be included in the release notes.