Add qualified endpoint for sending messages #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Highlights: - Add wireapp/generic-message-proto as a submodule - Expose only Proto endpoint for sending messages to qualified conversations Todo: - [ ] Add new integration tests for the qualified endpoint - [ ] Implement sending messages to local users, ignore remotes (to be done in a follow up PR)
akshaymankar
force-pushed
the
akshaymankar/fed-otr-message
branch
from
dc989d8 to
7fd715d
Compare
It is broken, the test prints ugly errors on failure :(
pcapriotti
reviewed
Jun 21, 2021
| :> UVerb 'POST '[Servant.JSON] PostOtrResponsesUnqualified, | ||
| postOtrMessage :: | ||
| routes | ||
| :- Summary "Post an encrypted message to a conversation (accepts JSON or Protobuf)" |
There was a problem hiding this comment.
The description looks wrong, since this endpoint does not accept JSON.
(observed by @mdimjasevic)
5 tasks
akshaymankar
commented
Jun 22, 2021
This was referenced Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
Todo:
follow up PR)