Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checklist for PRs #1601

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Add checklist for PRs #1601

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e04734
Add checklist for PRs
akshaymankar Jun 16, 2021
86bc425
Add entry for new flags and endpoints
akshaymankar Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
## Checklist

- [ ] Title of this PR explains the impact of the change.
- [ ] The description provides context as to why the change should occur and
what the code contributes to that effect. This could also be a link to a
JIRA ticket or a Github issue, if there is one.
- [ ] The CHANGELOG.md file in the *Unreleased* section has been updated to
explain the change which will be included in the release notes.
- [ ] If a component uses a new or changed internal endpoint of another
component, this is mentioned in the CHANGELOG.md.
akshaymankar marked this conversation as resolved.
Show resolved Hide resolved
- [ ] If this PR creates a new endpoint, or adds a new configuration flag, the endpoint / config-flag checklist (see Wire-employee only backend [wiki page](https://github.com/zinfra/backend-wiki/wiki/Checklists)) has been followed.