Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change conversationCodeURI in galley.yaml. #1643

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Jul 5, 2021

https://wearezeta.atlassian.net/browse/SQSERVICES-535

Mote context: (thanks @Yserz, and please correct me if I got anything wrong)

The old url was pointing to the webapp, and that will keep working as well as it works now, namely:

  • webapp can create and consume those links;
  • mobile clients can create, but not consume them.

In order to allow mobile clients to join conversations with the logged-in user (not a guest, that was harder to implement), the backend should now create new guest-links that point to the account pages under the new path. For web, this does not change anything, the new link will work as well as the old. For mobile, this will make things work via the logged-in user.

This PR makes sure that all tests, on-prem installations, ... can make this change. Until they do, things will work as well as (but not better than) before.

Checklist

  • Title of this PR explains the impact of the change.
  • The description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • The CHANGELOG.md file in the Unreleased section has been updated to explain the change which will be included in the release notes.
  • If a component uses a new or changed internal endpoint of another component, this is mentioned in the CHANGELOG.md.
  • If this PR creates a new endpoint, or adds a new configuration flag, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.

@fisx fisx requested a review from arianvp July 5, 2021 20:07
@arianvp
Copy link
Contributor

arianvp commented Jul 7, 2021

@fisx fisx merged commit e18641a into develop Jul 7, 2021
@fisx fisx deleted the SQSERVICES-535-conv-code-uri branch July 7, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants