Servant MultiVerb #1649
Merged
Servant MultiVerb #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcapriotti
force-pushed
the
pcapriotti/multiverb
branch
from
bc78f9e to
2f57302
Compare
Also convert conversation creation endpoints to use MultiVerb as a test case for headers.
5 tasks
By the time we find a content type mismatch, the handler has already run, so we should fail with FailFatal to avoid trying another handler.
mdimjasevic
approved these changes
Jul 19, 2021
It should use the underlying monoid instance of `UndenderResult Void`. Thanks @mdimjasevic for spotting this.
pcapriotti
force-pushed
the
pcapriotti/multiverb
branch
from
7f74b8a to
d2fa599
Compare
Comment on lines
85
to
86
| data UnrenderResult a = Mismatch | UnrenderError String | UnrenderSuccess a | ||
| deriving (Eq, Show, Functor) |
| type ResponseStatus (Respond s desc a) = s | ||
|
|
||
| responseRender (AcceptHeader acc) x = | ||
| M.mapAcceptMedia (map (uncurry mkRenderOutput) (allMimeRender (Proxy @cs) x)) acc |
There was a problem hiding this comment.
I know we don't use it, but for my education, would this make the server render output for all media types that the server supports and then choose which one to respond with? If so, we may want to rewrite this using M.matchAccept and then rendering?
| fromHeaders = id | ||
| toHeaders = id | ||
|
|
||
| data DescHeader (name :: Symbol) (desc :: Symbol) (a :: *) |
There was a problem hiding this comment.
I think it might be better to see if we could support having Servant.Description in the mods variable of Servant.Header'. Did you already try that? Might save us some code here and may even be easily upstream-able into servant-swagger.
akshaymankar
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new
Verb-like type for Servant endpoints:MultiVerb. TheMultiVerbtype can be used as an alternative toUVerb, and it provides approximately the same functionality as the latter, with a few differences:MultiVerbcan subsumeVerb.This PR only adds the
MultiVerbtype and uses it for the two user HEAD endpoints (qualified and unqualified). The followup PR #1657 appliesMultiVerbto a few other endpoints and makesErrorDescriptiontypes work asMultiVerbresponses.Checklist