Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test error responses #1680

Merged
merged 4 commits into from
Jul 26, 2021
Merged

Test error responses #1680

merged 4 commits into from
Jul 26, 2021

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Jul 23, 2021 •
edited
Loading

This PR adds integration tests to make sure that certain error responses behave as expected. This is mostly preparation for merging #1657.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If end-points have been added or changed: the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • Section Unreleased of CHANGELOG.md contains the following bits of information:
    • A line with the title and number of the PR in one or more suitable sub-sections.
    • If /a: measures to be taken by instance operators.
    • If /a: list of cassandra migrations.
    • If public end-points have been changed or added: does nginz need upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@pcapriotti pcapriotti marked this pull request as ready for review July 26, 2021 09:50
@pcapriotti pcapriotti merged commit 7a97cb5 into develop Jul 26, 2021
@pcapriotti pcapriotti deleted the pcapriotti/error-tests branch July 26, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jschaul jschaul jschaul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcapriotti @jschaul