Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

federator: Refactor RemoteError handling #1681

Merged
merged 3 commits into from
Sep 2, 2021
Merged

federator: Refactor RemoteError handling #1681

merged 3 commits into from
Sep 2, 2021

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Jul 23, 2021 •
edited
Loading

Small reorganisation of how RemoteErrors are thrown and logged in federator.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If end-points have been added or changed: the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • Section Unreleased of CHANGELOG.md contains the following bits of information:
    • A line with the title and number of the PR in one or more suitable sub-sections.
    • If /a: measures to be taken by instance operators.
    • If /a: list of cassandra migrations.
    • If public end-points have been changed or added: does nginz need upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@pcapriotti pcapriotti changed the base branch from develop to certificates-improvements July 23, 2021 14:08
@pcapriotti pcapriotti marked this pull request as ready for review July 27, 2021 07:35
Base automatically changed from certificates-improvements to develop July 27, 2021 07:53
@pcapriotti pcapriotti changed the base branch from develop to pcapriotti/client-certificates August 2, 2021 06:47
@pcapriotti pcapriotti force-pushed the pcapriotti/refactor-remote-v2 branch from 283fa4f to 82561d8 Compare August 2, 2021 06:47
akshaymankar
akshaymankar approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@pcapriotti pcapriotti force-pushed the pcapriotti/client-certificates branch 2 times, most recently from 78bdb9b to 24aa191 Compare August 9, 2021 10:13
Base automatically changed from pcapriotti/client-certificates to develop August 16, 2021 13:33
@jschaul
Copy link
Member

jschaul commented Aug 30, 2021

this needs a rebase.

@pcapriotti pcapriotti force-pushed the pcapriotti/refactor-remote-v2 branch from 098ef3d to 751c026 Compare August 31, 2021 07:03
@pcapriotti pcapriotti force-pushed the pcapriotti/refactor-remote-v2 branch from 751c026 to bc713d2 Compare September 1, 2021 11:49
@pcapriotti pcapriotti merged commit f759bb4 into develop Sep 2, 2021
@pcapriotti pcapriotti deleted the pcapriotti/refactor-remote-v2 branch September 2, 2021 05:55
@akshaymankar akshaymankar mentioned this pull request Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcapriotti @jschaul @akshaymankar