-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature flag "conferenceCalling" #1683
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update the docs/config-options.md and explain what it means for this to be enabled or disabled, and what the default is?
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No point in changing this now, but I would have preferred 2-3 smaller PRs (at least the unrelated tests should have been trivial to do separately).
@@ -17,8 +17,6 @@ license: AGPL-3 | |||
build-type: Simple | |||
extra-source-files: | |||
test/resources/integration-ca.pem | |||
test/resources/integration-leaf-key.pem | |||
test/resources/integration-leaf.pem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems unrelated?
https://wearezeta.atlassian.net/browse/SQSERVICES-681
This PR also:
feature-config.update
eventChecklist
make git-add-cassandra-schema
to update the cassandra schema documentation.