Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Federation] Remove the Obsolete Case of Managed Conversations in Member Removal #1718

Merged
merged 3 commits into from
Aug 30, 2021
Merged

[Federation] Remove the Obsolete Case of Managed Conversations in Member Removal #1718

merged 3 commits into from
Aug 30, 2021

Conversation

mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented Aug 27, 2021 •
edited
Loading

As confirmed by @jschaul , managed conversations are not supported any longer. This PR removes supporting them in conversation member removal.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If end-points have been added or changed: the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • Section Unreleased of CHANGELOG-draft.md contains the following bits of information:
    • A line with the title and number of the PR in one or more suitable sub-sections.
    • If /a: measures to be taken by instance operators.
    • If /a: list of cassandra migrations.
    • If public end-points have been changed or added: does nginz need upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

fisx
fisx approved these changes Aug 28, 2021
View reviewed changes
CHANGELOG-draft.md Show resolved Hide resolved
@mdimjasevic mdimjasevic merged commit d231550 into develop Aug 30, 2021
@mdimjasevic mdimjasevic deleted the mdimjasevic/fed-drop-managed-conv-from-rm branch August 30, 2021 11:50
@akshaymankar akshaymankar mentioned this pull request Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx fisx approved these changes

@jschaul jschaul Awaiting requested review from jschaul

@akshaymankar akshaymankar Awaiting requested review from akshaymankar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdimjasevic @fisx