Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Federation] Add OriginDomainHeader to /federation/update-conversation-memberships #1719

Merged
merged 2 commits into from
Aug 30, 2021
Merged

[Federation] Add OriginDomainHeader to /federation/update-conversation-memberships #1719

merged 2 commits into from
Aug 30, 2021

Conversation

mdimjasevic
Copy link
Contributor

@mdimjasevic mdimjasevic commented Aug 27, 2021 •
edited
Loading

Per Akshay's suggestion, this PR adds the OriginDomainHeader header to federated requests to the POST /federation/update-conversation-memberships endpoint.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If end-points have been added or changed: the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • Section Unreleased of CHANGELOG-draft.md contains the following bits of information:
    • A line with the title and number of the PR in one or more suitable sub-sections.
    • If /a: measures to be taken by instance operators.
    • If /a: list of cassandra migrations.
    • If public end-points have been changed or added: does nginz need upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

pcapriotti
pcapriotti approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mdimjasevic mdimjasevic merged commit f5854e4 into develop Aug 30, 2021
@mdimjasevic mdimjasevic deleted the mdimjasevic/fed-origin-dom-update-conv-mem branch August 30, 2021 09:18
@akshaymankar akshaymankar mentioned this pull request Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

@akshaymankar akshaymankar Awaiting requested review from akshaymankar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdimjasevic @pcapriotti