Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up JSON Golden Tests, Part 6 #1769

Merged
merged 7 commits into from
Sep 15, 2021
Merged

Clean up JSON Golden Tests, Part 6 #1769

merged 7 commits into from
Sep 15, 2021

Conversation

mdimjasevic
Copy link
Contributor

This patch further cleans up JSON golden tests. This is continuation of PRs #1729, #1732, #1733, #1756 and #1762.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information:
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@mdimjasevic mdimjasevic merged commit c90f3b7 into develop Sep 15, 2021
@mdimjasevic mdimjasevic deleted the mdimjasevic/reduce-golden-tests-part-6 branch September 15, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdimjasevic @akshaymankar