Build nginz and nginz_disco docker images using nix, too #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
jschaul
force-pushed
the
nixify-nginz-image
branch
from
c56c6a5 to
3d78283
Compare
jschaul
force-pushed
the
nixify-nginz-image
branch
from
01024eb to
0791a36
Compare
jschaul
force-pushed
the
nixify-nginz-image
branch
from
54ebac0 to
fb95685
Compare
jschaul
changed the title
flokli
reviewed
Oct 30, 2022
jschaul
force-pushed
the
nixify-nginz-image
branch
from
fb95685 to
a9127a6
Compare
jschaul
force-pushed
the
nixify-nginz-image
branch
from
a9127a6 to
1297fc2
Compare
|
What's the status of this? Still a draft, or ready to review? |
flokli
reviewed
Nov 3, 2022
flokli
reviewed
Nov 3, 2022
| }; | ||
| }; | ||
| in | ||
| nginzImage |
There was a problem hiding this comment.
This hides away the individual binaries, but it's a problem we also have with the haskell binaries, so happy to tackle this in a followup PR.
flokli
reviewed
Nov 3, 2022
flokli
reviewed
Nov 3, 2022
…ease either variables_hash_max_size: 1024 or variables_hash_bucket_size: 64; ignoring variables_hash_bucket_size
cannon has a preStop lifecycle hook that currently invokes nginx -c … quit on stop.
All config is defined in the helm chart, just by building the container we don't know which ports are exposed.
We use Nix to build this now.
jschaul
force-pushed
the
nixify-nginz-image
branch
from
ff90a61 to
09b10ac
Compare
Done. |
supersven
pushed a commit
that referenced
this pull request
Nov 22, 2022
* WIP * make inputs explicit * fixup for paths * use alpine base image * Support from flokli to fix issues * formatting * add nixified nginz-disco image * attempt to add to default.nix * nginx: [warn] could not build optimal variables_hash, you should increase either variables_hash_max_size: 1024 or variables_hash_bucket_size: 64; ignoring variables_hash_bucket_size * PR feedback: openssl 1.1 * changelog * also upload nginz and nginz-disco images * PR feedback * nix/nginz.nix: add nginz to contents cannon has a preStop lifecycle hook that currently invokes nginx -c … quit on stop. * nginz container: drop exposed ports All config is defined in the helm chart, just by building the container we don't know which ports are exposed. * services/nginz: drop Dockerfile, README and Makefile We use Nix to build this now. * Hi CI * remove no-longer-necessary openssl1.1 override Co-authored-by: Florian Klink <flokli@flokli.de>
This was referenced Nov 25, 2022
battermann
pushed a commit
that referenced
this pull request
Dec 12, 2022
* WIP * make inputs explicit * fixup for paths * use alpine base image * Support from flokli to fix issues * formatting * add nixified nginz-disco image * attempt to add to default.nix * nginx: [warn] could not build optimal variables_hash, you should increase either variables_hash_max_size: 1024 or variables_hash_bucket_size: 64; ignoring variables_hash_bucket_size * PR feedback: openssl 1.1 * changelog * also upload nginz and nginz-disco images * PR feedback * nix/nginz.nix: add nginz to contents cannon has a preStop lifecycle hook that currently invokes nginx -c … quit on stop. * nginz container: drop exposed ports All config is defined in the helm chart, just by building the container we don't know which ports are exposed. * services/nginz: drop Dockerfile, README and Makefile We use Nix to build this now. * Hi CI * remove no-longer-necessary openssl1.1 override Co-authored-by: Florian Klink <flokli@flokli.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO before merging:
Checklist
changelog.d