Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/nginz/third_party/nginx-module-vts: drop submodule #2836

Merged
merged 2 commits into from
Nov 9, 2022

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Nov 8, 2022

We use nginxModules.vts from nixpkgs now instead, so there's no need to keep the submodule around.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d covered by changelog.d/5-internal/nginz-nix
  • Read and follow the PR guidelines

@flokli flokli temporarily deployed to cachix November 8, 2022 18:41 Inactive
@flokli flokli temporarily deployed to cachix November 8, 2022 18:41 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Nov 8, 2022
We use nginxModules.vts from nixpkgs now instead, so there's no need to keep
the submodule around.
We use nginxModules.moreheaders from nixpkgs now instead, so there's no need to
keep the submodule around.
@flokli flokli force-pushed the remove-nginx-vts-submodule branch from 9b2dc1a to bc3cc61 Compare November 8, 2022 18:44
@flokli flokli temporarily deployed to cachix November 8, 2022 18:44 Inactive
@flokli flokli temporarily deployed to cachix November 8, 2022 18:44 Inactive
@jschaul jschaul merged commit 5733150 into develop Nov 9, 2022
@jschaul jschaul deleted the remove-nginx-vts-submodule branch November 9, 2022 16:55
supersven pushed a commit that referenced this pull request Nov 22, 2022
…ules (#2836)

We use nginxModules.vts from nixpkgs now instead, so there's no need to keep
the submodules around.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants