-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQSERVICES-253] Support provisioning role information with scim PATCH
#2855
[SQSERVICES-253] Support provisioning role information with scim PATCH
#2855
Conversation
PATCH
e6512c5
to
f4c4f88
Compare
bc357cd
to
fbdaec6
Compare
6984090
to
7455f79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
i have two nit-picks, but they can either be done in a future release or forgotten entirely.
let testWithInitialRole r = forM_ [minBound .. maxBound] (testPatchRoles brig replaceOrAdd tid owner tok r) | ||
forM_ [minBound .. maxBound] testWithInitialRole |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i suggested a different way to write this, but this time i have another suggestion :-)
let testWithInitialRole r = forM_ [minBound .. maxBound] (testPatchRoles brig replaceOrAdd tid owner tok r) | |
forM_ [minBound .. maxBound] testWithInitialRole | |
let values = [[], ["member", "admin"], ["notarole"]] <> (:[]) <$> [minBound .. maxBound] | |
testWithInitialRole r = forM_ values (testPatchRoles brig replaceOrAdd tid owner tok r) | |
forM_ values testWithInitialRole |
(this would require to take [Role]
instead of Role
in initial and target below.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this trick could also be used to simplify the tests for POST
, PUT
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i suggested a different way to write this, but this time i have another suggestion :-)
I know, but that didn't compile, and I tried to come as close as possible.
https://wearezeta.atlassian.net/browse/SQSERVICES-253
support for
PATCH
Checklist
changelog.d