Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hlint: fix inplace option, less verbosity on ci #2865

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Nov 24, 2022

This PR fixes some issues of the ./tools/hlint.sh script

  • adds the missing refactor binary to nix. Without the -m inplace option doesn't work
  • adds missing implementation for the -f all -m inplace combination
  • Removes verbosity for -f all -m check. This prevents a wall of text on our CI and makes it easier to read the suggestions of hlint

@smatting smatting temporarily deployed to cachix November 24, 2022 09:36 Inactive
@smatting smatting temporarily deployed to cachix November 24, 2022 09:36 Inactive
@smatting smatting requested a review from elland November 24, 2022 09:37
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Nov 24, 2022
@smatting smatting temporarily deployed to cachix November 24, 2022 09:41 Inactive
@smatting smatting temporarily deployed to cachix November 24, 2022 09:41 Inactive
tools/hlint.sh Show resolved Hide resolved
tools/hlint.sh Show resolved Hide resolved
@smatting smatting merged commit 11ea556 into develop Nov 24, 2022
@smatting smatting deleted the smatting/hlint-fix branch November 24, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants