-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add initial delay seconds to brig liveness and readiness probes #2878
Conversation
@@ -138,11 +138,13 @@ spec: | |||
scheme: HTTP | |||
path: /i/status | |||
port: {{ .Values.service.internalPort }} | |||
initialDelaySeconds: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your problem would be better solved with a startup probe, see also https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/
startupProbe:
httpGet:
...
failureThreshold: 6
periodSeconds: 5
That would wait for 30 seconds before moving over to the liveness probe which restarts brig.
Overall, if /i/status fails, however, then this begs the question if the installation works correctly otherwise? If brig doesn't have enough resources likely users will not have adequate latencies either.
Also, could it be that something else regarding networking is not working as it should, rather than this just being a resource problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, yes the startupProbe make more sense here, added it.
Yeah, there can be issues due to high network latencies as well, there is a argument "timeoutSeconds", which has default value of 1 second. Maybe, we can increase that as well for these probes.
@amitsagtani97 PR looks good now; could you add one line to a changelog file (maybe under internal) then this PR is good to be (squash-) merged. |
Ticket - https://wearezeta.atlassian.net/browse/SQPIT-491
Brig pods continuously restarts in case of liveness and readiness probes failing on the startup in the low compute resource environment.
To reproduce -
Added a initial delay before running first liveness and readiness probe, which allows all the brig containers to start on a low resource environment before running the probes.
Checklist
changelog.d