-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQSERVICES-1773] Allow pagination for team search endpoints - has_more
#2898
[SQSERVICES-1773] Allow pagination for team search endpoints - has_more
#2898
Conversation
c088c65
to
e795d32
Compare
e795d32
to
4e2e61d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog. You can extend the one from the previous PR by listing both PR numbers, which should look nice in the release notes.
The part I didn't get is +1; a comment is inlined.
Furthermore, is there a way for the API user to iterate over result pages?
let (IndexQuery q f sortSpecs) = teamUserSearchQuery tid mbSearchText mRoleFilter mSortBy mSortOrder | ||
idx <- asks idxName | ||
let search = | ||
(ES.mkSearch (Just q) (Just f)) | ||
{ ES.size = ES.Size (fromIntegral s), | ||
{ ES.size = ES.Size (fromIntegral size + 1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it + 1?
Good points, I'll add a comment about the +1 and update the changelog.
Not sure what you mean exactly. This PR adds the |
Ok, that's what I was asking about. Thanks for clarifying. Given the experience with the Cassandra paging endpoints, I expect client devs to be asking how to use this Es paging system. Perhaps it'd be good to include a thorough description in Swagger analogous to the way the Cassandra paging endpoints have it, by extending the endpoint description. |
I updated the docs, and tried to be more clear. From the client perspective, ES's and C*'s paging mechanisms works exactly the same. In other words, the API is the same (only the implementation differs). So I assume they are already fairly familiar with it. However, it can't hurt to be more clear. |
This is an extension of #2895 and adds the
has_more
field to the search result.https://wearezeta.atlassian.net/browse/SQSERVICES-1773
Checklist