Fail on MLS endpoints in galley when MLS is not enabled #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
pcapriotti
changed the title
pcapriotti
force-pushed
the
pcapriotti/develop-mls-cleanups
branch
from
ff3672b to
13cedd1
Compare
We are now treating the absence of a removal key as an indicator that MLS is disabled on this backend, and throw a 400 error on all Galley endpoints that have something to do with MLS.
The federation endpoints `mls-welcome` and `on-mls-message-sent` will now fail and return an error value when MLS is not enabled on the receiving side.
pcapriotti
force-pushed
the
pcapriotti/develop-mls-cleanups
branch
from
13cedd1 to
c61776d
Compare
smatting
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all galley endpoints related to MLS fail early when MLS is not enabled. For now, MLS is considered "enabled" when the MLS removal key is set.
Note that this breaks the federation API, because it introduces return values in endpoints such as
send-mls-welcomeandon-mls-message-sentto support the possibility of them failing.Checklist
changelog.d