Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional subconversation field to conversation events #2933

Merged
merged 3 commits into from
Dec 19, 2022

Conversation

smatting
Copy link
Contributor

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@smatting smatting marked this pull request as ready for review December 16, 2022 14:19
@smatting smatting temporarily deployed to cachix December 16, 2022 14:19 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 16, 2022 14:19 — with GitHub Actions Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 16, 2022
@@ -291,6 +306,7 @@ testObject_Event_user_16 :: Event
testObject_Event_user_16 =
Event
(Qualified (Id (fromJust (UUID.fromString "6ec1c834-9ae6-4825-8809-61dde80be5ea"))) (Domain "faraway.example.com"))
Nothing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No examples with data present?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test case

@smatting smatting force-pushed the FS-900/subconv-events branch from 16a830e to b7974b2 Compare December 19, 2022 08:55
@smatting smatting temporarily deployed to cachix December 19, 2022 08:55 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 19, 2022 08:55 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 19, 2022 09:03 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 19, 2022 09:03 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic self-requested a review December 19, 2022 09:18
@smatting smatting merged commit 9ab536b into develop Dec 19, 2022
@smatting smatting deleted the FS-900/subconv-events branch December 19, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants