Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add federated endpoints to get subconversations #2952

Merged
merged 10 commits into from
Dec 27, 2022
Merged

Add federated endpoints to get subconversations #2952

merged 10 commits into from
Dec 27, 2022

Conversation

smatting
Copy link
Contributor

@smatting smatting commented Dec 27, 2022 •
edited
Loading

https://wearezeta.atlassian.net/browse/FS-901

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@smatting smatting temporarily deployed to cachix December 27, 2022 09:48 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 27, 2022 09:48 — with GitHub Actions Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Dec 27, 2022
@mdimjasevic mdimjasevic force-pushed the FS-901-followup-federated-get branch from 649c126 to 084135f Compare December 27, 2022 10:26
@mdimjasevic mdimjasevic temporarily deployed to cachix December 27, 2022 10:26 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 27, 2022 10:26 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 27, 2022 11:37 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 27, 2022 11:37 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 27, 2022 11:39 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 27, 2022 11:39 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 27, 2022 11:57 — with GitHub Actions Inactive
@smatting smatting temporarily deployed to cachix December 27, 2022 11:57 — with GitHub Actions Inactive
@smatting smatting changed the title Add federated get subconversation endpoint Add federated endpoints to get subconversations Dec 27, 2022
@smatting smatting marked this pull request as ready for review December 27, 2022 11:58
@mdimjasevic mdimjasevic force-pushed the FS-901-followup-federated-get branch from ef1aff8 to c834a2e Compare December 27, 2022 14:21
@mdimjasevic mdimjasevic temporarily deployed to cachix December 27, 2022 14:21 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 27, 2022 14:21 — with GitHub Actions Inactive
mdimjasevic
mdimjasevic approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed some unused constraints in the SubConversation module. Otherwise this looks good.

@mdimjasevic mdimjasevic temporarily deployed to cachix December 27, 2022 15:25 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic temporarily deployed to cachix December 27, 2022 15:25 — with GitHub Actions Inactive
@mdimjasevic mdimjasevic merged commit afa0fbf into mls Dec 27, 2022
@mdimjasevic mdimjasevic deleted the FS-901-followup-federated-get branch December 27, 2022 16:11
@stefanwire stefanwire mentioned this pull request Jan 17, 2023
Merged
9 tasks
This was referenced Oct 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdimjasevic mdimjasevic mdimjasevic approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smatting @mdimjasevic @zebot