Fix ToSchema Version instance.
#2978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts commit 6f91151.
zebot
added
the
ok-to-test
elland
reviewed
Jan 12, 2023
| constructed = | ||
| -- (fromEnum doesn't work as soon as we drop support for V0.) | ||
| (\v -> (read . Imports.tail . show $ v, v)) <$> [minBound @Version ..] | ||
| explicit = |
There was a problem hiding this comment.
I don't like how easy it is to forget or make a mistake about this, but I don't have a better idea in mind at the moment. 😰
There was a problem hiding this comment.
what do you mean? how would you do a mistake here that'd go uncaught by the CI?
There was a problem hiding this comment.
I mean forgetting to add / update versions and it not being caught by GHC/ type checking. But hopefully CI is enough to prevent us from messing up 🤞
pcapriotti
reviewed
Jan 12, 2023
my idea was that this way, you get an error in the integration tests if you forget to update but i'll let you decide: please approve or reject. |
pcapriotti
requested changes
Jan 13, 2023
elland
approved these changes
Jan 16, 2023
pcapriotti
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts commit 6f91151 (#2965).
I think I've overkilled it, but I wanted it to be safe!
Checklist
changelog.d