Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook fedcalls into api docs #2988

Merged
merged 8 commits into from
Jan 20, 2023
Merged

Hook fedcalls into api docs #2988

merged 8 commits into from
Jan 20, 2023

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Jan 16, 2023

Follow-up to #2973. Title says it all.

2023-01-16-103727_1920x1080_scrot

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

fisx added 3 commits January 16, 2023 09:57
(Will also include fed calls from now on, and anyway an API is always
both a server and a client API, or it wouldn't work at all.)
(it's gotten better since 2020)
@fisx fisx temporarily deployed to cachix January 16, 2023 09:39 — with GitHub Actions Inactive
@fisx fisx temporarily deployed to cachix January 16, 2023 09:39 — with GitHub Actions Inactive
@fisx fisx force-pushed the hook-fedcalls-into-api-docs branch from d903be3 to a99c8db Compare January 16, 2023 09:39
@fisx fisx temporarily deployed to cachix January 16, 2023 09:39 — with GitHub Actions Inactive
@fisx fisx temporarily deployed to cachix January 16, 2023 09:39 — with GitHub Actions Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 16, 2023
@fisx
Copy link
Contributor Author

fisx commented Jan 16, 2023

@arthurwolf I'm pretty confident I have violated the spirit of the structure of wire-docs. Could you show me what needs to be changed?

@arthurwolf
Copy link
Contributor

arthurwolf commented Jan 18, 2023

I'm pretty confident I have violated the spirit of the structure of wire-docs. Could you show me what needs to be changed?

Yes, you want anything federation-related to go into the federation/ side of documentation.

If you move the new content there, it should then be fine, ping me and i'll review then (or tell me if you want me to do the move, and i'll try to)

@fisx fisx temporarily deployed to cachix January 19, 2023 09:56 — with GitHub Actions Inactive
@fisx fisx temporarily deployed to cachix January 19, 2023 09:56 — with GitHub Actions Inactive
@fisx
Copy link
Contributor Author

fisx commented Jan 19, 2023

Yes, you want anything federation-related to go into the federation/ side of documentation.

done! could you take another look?

Copy link
Contributor

@arthurwolf arthurwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@fisx fisx merged commit 73d79d3 into develop Jan 20, 2023
@fisx fisx deleted the hook-fedcalls-into-api-docs branch January 20, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants