Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart compatibility kubernetes 1.22 #3002

Merged
merged 5 commits into from
Jan 19, 2023
Merged

Chart compatibility kubernetes 1.22 #3002

merged 5 commits into from
Jan 19, 2023

Conversation

jschaul
Copy link
Member

@jschaul jschaul commented Jan 18, 2023

Ingress compatibility k8s 1.22 and beyond

See https://kubernetes.io/docs/reference/using-api/deprecation-guide/ and https://www.sobyte.net/post/2021-11/helm-chart-compatible-different-kube-versio/

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@jschaul jschaul temporarily deployed to cachix January 18, 2023 13:00 — with GitHub Actions Inactive
@jschaul jschaul temporarily deployed to cachix January 18, 2023 13:00 — with GitHub Actions Inactive
@jschaul jschaul requested review from supersven and sysvinit January 18, 2023 13:00
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 18, 2023
@jschaul jschaul requested a review from akshaymankar January 18, 2023 13:01
@jschaul jschaul temporarily deployed to cachix January 18, 2023 13:40 — with GitHub Actions Inactive
@jschaul jschaul temporarily deployed to cachix January 18, 2023 13:40 — with GitHub Actions Inactive
@jschaul jschaul temporarily deployed to cachix January 18, 2023 13:41 — with GitHub Actions Inactive
@jschaul jschaul temporarily deployed to cachix January 18, 2023 13:41 — with GitHub Actions Inactive
@jschaul jschaul force-pushed the chart-compatibility-kubernetes-1.22 branch from c9379d3 to a347ff1 Compare January 18, 2023 14:15
@jschaul jschaul temporarily deployed to cachix January 18, 2023 14:15 — with GitHub Actions Inactive
@jschaul jschaul temporarily deployed to cachix January 18, 2023 14:15 — with GitHub Actions Inactive
@akshaymankar
Copy link
Member

Doesn't seem to work:

  Error: unable to build kubernetes objects from release manifest: error validating "": error validating data: apiVersion not set

Running helm template on ingress-nginx-services and staring at all the YAMLs might help.

@jschaul jschaul temporarily deployed to cachix January 19, 2023 11:50 — with GitHub Actions Inactive
@jschaul jschaul temporarily deployed to cachix January 19, 2023 11:50 — with GitHub Actions Inactive
@jschaul
Copy link
Member Author

jschaul commented Jan 19, 2023

A -}} lead to a newline break being removed after a comment, thus it commenting out the apiVersion: ... block. CI is green now.

@jschaul jschaul merged commit 58b7617 into develop Jan 19, 2023
@jschaul jschaul deleted the chart-compatibility-kubernetes-1.22 branch January 19, 2023 14:10
@jschaul jschaul mentioned this pull request Jan 25, 2023
Merged
2 tasks
@zebot zebot mentioned this pull request Jan 26, 2023
Merged
jschaul added a commit that referenced this pull request Jan 30, 2023
@jschaul
fixup to federator ingress helm chart syntax from the changes in #3002
213d319
@jschaul jschaul mentioned this pull request Jan 30, 2023
Merged
smatting pushed a commit that referenced this pull request Jan 30, 2023
@jschaul
fixup to federator ingress helm chart syntax from the changes in #3002 (
335b53a 
#3034)
supersven pushed a commit that referenced this pull request Feb 10, 2023
@jschaul @supersven
fixup to federator ingress helm chart syntax from the changes in #3002 (
0f35c5f 
#3034)
@jschaul jschaul mentioned this pull request Feb 21, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

@supersven supersven Awaiting requested review from supersven

@sysvinit sysvinit Awaiting requested review from sysvinit

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jschaul @akshaymankar @zebot