-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Servantify /teams/notifications #3020
Merged
supersven
merged 8 commits into
develop
from
sventennie/servantify_last_old_swagger_endpoint
Feb 8, 2023
Merged
Servantify /teams/notifications #3020
supersven
merged 8 commits into
develop
from
sventennie/servantify_last_old_swagger_endpoint
Feb 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
label
Jan 26, 2023
supersven
force-pushed
the
sventennie/servantify_last_old_swagger_endpoint
branch
from
February 8, 2023 11:22
cc3bd6c
to
5a07e3c
Compare
pcapriotti
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
libs/wire-api/src/Wire/API/Routes/Public/Galley/TeamNotification.hs
Outdated
Show resolved
Hide resolved
battermann
approved these changes
Feb 8, 2023
libs/wire-api/src/Wire/API/Routes/Public/Galley/TeamNotification.hs
Outdated
Show resolved
Hide resolved
libs/wire-api/src/Wire/API/Routes/Public/Galley/TeamNotification.hs
Outdated
Show resolved
Hide resolved
…on.hs Co-authored-by: Leif Battermann <leif.battermann@wire.com>
…on.hs Co-authored-by: Leif Battermann <leif.battermann@wire.com>
@pcapriotti , @battermann : Thanks a lot! |
supersven
added a commit
that referenced
this pull request
Feb 10, 2023
Co-authored-by: Leif Battermann <leif.battermann@wire.com> Co-authored-by: Leif Battermann <leif.battermann@wire.com>
This was referenced Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I left the old Swagger
Doc
models untouched. But, I migrated the existing Swagger fields as good as possible. Removing old Swagger from our code base (including relatedDoc
models) will be the next step.Ticket
Checklist
changelog.d