Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servantify /teams/notifications #3020

Merged
merged 8 commits into from
Feb 8, 2023

Conversation

supersven
Copy link
Contributor

@supersven supersven commented Jan 26, 2023

I left the old Swagger Doc models untouched. But, I migrated the existing Swagger fields as good as possible. Removing old Swagger from our code base (including related Doc models) will be the next step.

Ticket

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@supersven supersven temporarily deployed to cachix January 26, 2023 09:17 — with GitHub Actions Inactive
@supersven supersven temporarily deployed to cachix January 26, 2023 09:17 — with GitHub Actions Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jan 26, 2023
@supersven supersven force-pushed the sventennie/servantify_last_old_swagger_endpoint branch from cc3bd6c to 5a07e3c Compare February 8, 2023 11:22
@supersven supersven marked this pull request as ready for review February 8, 2023 14:03
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

supersven and others added 2 commits February 8, 2023 15:38
…on.hs

Co-authored-by: Leif Battermann <leif.battermann@wire.com>
…on.hs

Co-authored-by: Leif Battermann <leif.battermann@wire.com>
@supersven
Copy link
Contributor Author

@pcapriotti , @battermann : Thanks a lot!

@supersven supersven merged commit e8d5492 into develop Feb 8, 2023
@supersven supersven deleted the sventennie/servantify_last_old_swagger_endpoint branch February 8, 2023 15:30
supersven added a commit that referenced this pull request Feb 10, 2023
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants