Helm hook type #3049
Merged
Helm hook type #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
akshaymankar
approved these changes
Feb 2, 2023
2 tasks
supersven
pushed a commit
that referenced
this pull request
Feb 10, 2023
* change helm hook type of test resources which are not Pods * changelog adjustment
This was referenced Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defining configmaps/secrets/services as helm hook type of "test" has the disadvantage of not being able to use
helm test --filter name=...as done in #3040Originally, the motivation for #3037 was to be able to go from a clusterIP-based service to a headless service. marking these as hooks with a delete policy should achieve the same result.
Checklist
changelog.d