Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old swagger #3066

Merged
merged 14 commits into from
Feb 10, 2023
Merged

remove old swagger #3066

merged 14 commits into from
Feb 10, 2023

Conversation

supersven
Copy link
Contributor

@supersven supersven commented Feb 8, 2023 •
edited
Loading

This PR accomplishes two things:

  • Delete the endpoints of old Swagger docs.
  • Remove all traces of the (now unused) old swagger library from our code.

Ticket

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@supersven supersven changed the title Sventennie/remove old swagger remove old swagger Feb 8, 2023
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 8, 2023
@supersven supersven force-pushed the sventennie/remove_old_swagger branch 3 times, most recently from 6738a20 to a14112e Compare February 10, 2023 13:35
@supersven supersven force-pushed the sventennie/remove_old_swagger branch from a14112e to 98fbed2 Compare February 10, 2023 13:52
@supersven supersven marked this pull request as ready for review February 10, 2023 14:20
pcapriotti
pcapriotti approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at this thoroughly, but I don't see anything suspicious, so I'd say 🚢 .

@supersven supersven merged commit 6c4b00e into develop Feb 10, 2023
@supersven supersven deleted the sventennie/remove_old_swagger branch February 10, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@supersven @pcapriotti @zebot