Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Haddock for TeamBinding #3087

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

supersven
Copy link
Contributor

Add some wisdom of @akshaymankar to TeamBinding. 😸

Checklist

  • new entry in changelog.d: Not needed!
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 15, 2023
@supersven supersven marked this pull request as ready for review February 15, 2023 13:45
-- A `NonBinding` team is a concept only in the backend. It is a team someone
-- can create and someone who has an account on Wire can join that team. This
-- way, in theory, one person can join many teams. This concept never made it as
-- a concept of product, but got used a lot of writing integration tests. Newer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-- a concept of product, but got used a lot of writing integration tests. Newer
-- a concept of product, but got used a lot for writing integration tests. Newer

@supersven
Copy link
Contributor Author

@battermann explained that this binding / non-binding stuff will be removed in the upcoming sprint. Thus, closing this PR.

@supersven supersven closed this Feb 15, 2023
@mdimjasevic
Copy link
Contributor

@battermann explained that this binding / non-binding stuff will be removed in the upcoming sprint. Thus, closing this PR.

I suppose it wouldn't hurt us if we merged this PR. Then whoever would be removing this feature would delete the documentation too. And of course there is a chance this doesn't get worked on in the upcoming sprint, leaving us with no benefit.

@supersven supersven reopened this Feb 16, 2023
@supersven supersven merged commit bc50e60 into develop Feb 16, 2023
@supersven supersven deleted the sventennie/teambinding_haddock branch February 16, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants