Coturn container image update errata

[sysvinit]

This is a follow-up to #3078. The pre-stop hook script was not updated when some metrics were relabeled in the update from 4.5.2 to 4.6.0, which would mean that the script would inadvertently exit while there were still active TURN sessions in the coturn process. This change updates the coturn image to a version with a fixed pre-stop hook script.

Checklist

• Add a new entry in an appropriate subdirectory of changelog.d
• Read and follow the PR guidelines

[jschaul]

shrug. Fine for me.

The other containers we build make use of dumb-init , see e.g.

wire-server/nix/wire-server.nix

Line 247 in 6a6bcd7

Entrypoint = [ "${pkgs.dumb-init}/bin/dumb-init" "--" "${drv}/bin/${execName}" ];

to do sane signal handling inside a container.

These version numbers like 4.6.0-wireapp.4 - how do I know which code they correspond to? There's no git tag or similar I can see inside wireapp/coturn, so I have no idea how this image was built and what code it relates to. How do you look this up? Could we tag git commits with this version number so people could know what this number refers to?

[sysvinit]

The other containers we build make use of dumb-init

Our coturn container image is based on the upstream container image, which itself is based on Debian and runs coturn as PID 1. See e.g. this Dockerfile for the base image, this Dockerfile which adds the graceful shutdown hook, and the coturn pipeline in Concourse.

These version numbers like 4.6.0-wireapp.4 - how do I know which code they correspond to? There's no git tag or similar I can see inside wireapp/coturn, so I have no idea how this image was built and what code it relates to. How do you look this up? Could we tag git commits with this version number so people could know what this number refers to?

The tags in wireapp/coturn are prefixed with the string wireapp/, to distinguish them from upstream tags. So, the code for the image 4.6.0-wireapp.4 can be found at the tag wireapp/4.6.0-wireapp.4. These version numbers are incremented automatically in the Concourse pipeline too.