Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Members into multiple constraints #3093

Merged
merged 5 commits into from
Feb 17, 2023
Merged

Split Members into multiple constraints #3093

merged 5 commits into from
Feb 17, 2023

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Feb 16, 2023 •
edited
Loading

This PR splits all Polysemy Members constraints into multiple Member constraints. This makes it possible for -Wredundant-constraints to trigger and flag numerous redundant items.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti pcapriotti force-pushed the pcapriotti/split-member-constraints branch from 2d51245 to c03fa18 Compare February 17, 2023 09:48
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 17, 2023
mdimjasevic
mdimjasevic approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@mdimjasevic mdimjasevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine.

It would be great if you added a changelog; it's a quite big change (in terms of the number of lines).

@pcapriotti pcapriotti force-pushed the pcapriotti/split-member-constraints branch from c03fa18 to cd5c9e9 Compare February 17, 2023 11:00
@stefanwire stefanwire merged commit c27541d into develop Feb 17, 2023
@stefanwire stefanwire deleted the pcapriotti/split-member-constraints branch February 17, 2023 11:45
This was referenced Mar 6, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanwire stefanwire stefanwire approved these changes

@mdimjasevic mdimjasevic mdimjasevic approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcapriotti @mdimjasevic @stefanwire @zebot