Fix dpop access token test #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
battermann
force-pushed
the
battermann/fix-dpop-access-token-test
branch
from
3e92e44 to
5d7b5f5
Compare
zebot
added
the
ok-to-test
fisx
approved these changes
Mar 6, 2023
|
do you know how this made it past the CI? |
Yes, when CI ran and succeeded, the hard coded token was still valid. It probably expired over the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the test for the
jwt-toolsrust FFI we used a hard coded proof with a very short expiration time.Replaced it with a proof with max expiration time (until 2038).
Checklist
changelog.d