Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add conversation type to group ID serialisation #3344

Merged
merged 4 commits into from
Jun 15, 2023
Merged

add conversation type to group ID serialisation #3344

merged 4 commits into from
Jun 15, 2023

Conversation

stefanwire
Copy link
Contributor

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@stefanwire stefanwire requested a review from pcapriotti June 9, 2023 11:45
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Jun 9, 2023
pcapriotti
pcapriotti approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe one thing I would change is make the internal endpoint take a group ID instead of its parts. Then we wouldn't need to add bytestring conversion functions for ConvType.

@stefanwire stefanwire force-pushed the WPB-1925 branch 2 times, most recently from 98834f3 to 8a1a3e7 Compare June 14, 2023 13:58
@stefanwire stefanwire force-pushed the WPB-1925 branch 2 times, most recently from 6f0e670 to 5de3d4f Compare June 14, 2023 14:48
@stefanwire stefanwire merged commit 241a588 into mls Jun 15, 2023
@stefanwire stefanwire deleted the WPB-1925 branch June 15, 2023 10:31
This was referenced Oct 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcapriotti pcapriotti pcapriotti approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanwire @pcapriotti @zebot