Handle unreachable backends when adding users #3496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
pcapriotti
force-pushed
the
pcapriotti/unreachable-add
branch
from
02faab1 to
3a46d96
Compare
pcapriotti
force-pushed
the
pcapriotti/unreachable
branch
from
1b26dfe to
fac5b1b
Compare
pcapriotti
force-pushed
the
pcapriotti/unreachable-add
branch
from
3a46d96 to
a839198
Compare
pcapriotti
force-pushed
the
pcapriotti/unreachable-add
branch
from
a839198 to
9722d2e
Compare
mdimjasevic
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking for unreachable backends when a user is added to a conversation is already done as part of #3486. This PR is just a small refactoring and some new tests.
https://wearezeta.atlassian.net/browse/WPB-3602
Checklist
changelog.d