Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support x509 credentials #3532

Merged
merged 5 commits into from
Aug 25, 2023
Merged

Support x509 credentials #3532

merged 5 commits into from
Aug 25, 2023

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Aug 23, 2023

This PR adds minimal support for x509 credentials in MLS.

At the moment, this is based on the x509 branch of mls-test-cli.

https://wearezeta.atlassian.net/browse/WPB-3787

Checklist

  • Update nix package for mls-test-cli
  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 23, 2023
@pcapriotti pcapriotti force-pushed the pcapriotti/mls-x509 branch from a941c47 to 800f066 Compare August 24, 2023 12:20
@pcapriotti pcapriotti force-pushed the pcapriotti/mls-x509 branch from 800f066 to 5e2aad9 Compare August 25, 2023 06:55
@pcapriotti pcapriotti marked this pull request as ready for review August 25, 2023 07:13
@pcapriotti pcapriotti merged commit 995f28c into mls Aug 25, 2023
@pcapriotti pcapriotti deleted the pcapriotti/mls-x509 branch August 25, 2023 09:18
pcapriotti added a commit that referenced this pull request Sep 27, 2023
* Add options to createMLSClient

* Add failing test with x509 key packages

* Support x509 credentials

* Add CHANGELOG entry

* Upgrade mls-test-cli to version supporting x509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants