Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save MLS migration statistics in S3 bucket #3579

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Save MLS migration statistics in S3 bucket #3579

merged 3 commits into from
Oct 5, 2023

Conversation

stefanwire
Copy link
Contributor

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 13, 2023
@stefanwire stefanwire force-pushed the mlsstats branch 2 times, most recently from 2612db3 to c15e39f Compare September 18, 2023 09:11
@stefanwire stefanwire force-pushed the mlsstats branch 3 times, most recently from 54d3d12 to 25c9bd4 Compare September 22, 2023 14:13
@stefanwire stefanwire marked this pull request as ready for review September 22, 2023 15:57
akshaymankar
akshaymankar reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the helm things, reviewing haskell next.

charts/mlsstats/templates/cronjob.yaml Outdated Show resolved Hide resolved
charts/mlsstats/templates/cronjob.yaml Outdated Show resolved Hide resolved
charts/mlsstats/templates/cronjob.yaml Outdated Show resolved Hide resolved
charts/mlsstats/templates/cronjob.yaml Outdated Show resolved Hide resolved
charts/mlsstats/templates/cronjob.yaml Outdated Show resolved Hide resolved
charts/mlsstats/templates/secret.yaml Outdated Show resolved Hide resolved
tools/mlsstats/exec/Main.hs Outdated Show resolved Hide resolved
charts/wire-server/requirements.yaml Outdated Show resolved Hide resolved
hack/helmfile.yaml Outdated Show resolved Hide resolved
hack/helmfile.yaml Outdated Show resolved Hide resolved
akshaymankar
akshaymankar reviewed Sep 25, 2023
View reviewed changes
Copy link
Member

@akshaymankar akshaymankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also reviewed haskal

tools/mlsstats/src/MlsStats/Run.hs Outdated Show resolved Hide resolved
tools/mlsstats/src/MlsStats/Run.hs Outdated Show resolved Hide resolved
tools/mlsstats/src/MlsStats/Run.hs Outdated Show resolved Hide resolved
@stefanwire stefanwire merged commit 1afd924 into mls Oct 5, 2023
@stefanwire stefanwire deleted the mlsstats branch October 5, 2023 07:49
This was referenced Oct 19, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshaymankar akshaymankar akshaymankar approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanwire @akshaymankar @zebot