WPB-3797 do not cache federation remote domain config #3612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…che-federation-remote-domain-config
|
|
lepsa
changed the base branch from
WPB-3797/do-not-cache-federation-remote-domain-config
to
develop
…che-federation-remote-domain-config
…che-federation-remote-domain-config
elland
added
the
ok-to-test
elland
approved these changes
Sep 27, 2023
MangoIV
pushed a commit
that referenced
this pull request
Oct 9, 2023
--------- Co-authored-by: Matthias Fischmann <mf@zerobuzz.net> Co-authored-by: Igor Ranieri <igor@elland.me>
This was referenced Oct 19, 2023
echoes-hq
bot
added
the
echoes: technical-roadmap/technical-debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removing the domain caching and sync threads from background worker and federator. Galley already had this code removed.
Notes
Background worker is deriving the list of domains from the Rabbit queues, and I find this strange. This code is coming in from
develop, so I've left it alone as changing it over to pull directly from Brig causes problems in the integration tests.Checklist
changelog.d