[fix] some fixes related to nix #3628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zebot
added
the
ok-to-test
MangoIV
force-pushed
the
mangoiv/nix/reproducibility-improvements
branch
5 times, most recently
from
12064bf to
4514741
Compare
- repair fixed output derivation cargo packages - add benchmarkdepends to the devShell - make the missing build-tool-depends more reproducible
MangoIV
force-pushed
the
mangoiv/nix/reproducibility-improvements
branch
from
4514741 to
25b1fb9
Compare
akshaymankar
reviewed
Oct 5, 2023
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-4959
https://wearezeta.atlassian.net/browse/WPB-4961
devShellCurrently there are four dependencies (two packages) that cabal is not able to pull from the environment, which are
I have specified an
index-stateand a repository for people (like me) who don't have a global repository installed.This is not too nice, because as you can see, it doesn't pick the version of
hspec-discoverintended by thepkgs' haskell packages set. I think best would be to pin this somewhere, perhaps in acabal.project.freezefile (which would need regenerating each time the nixpkgs haskell package set is updated) or directly in the cabal files (which I guess is also hard to maintain).As far as I can tell this is related to this issue: NixOS/nixpkgs#176887
Fixes #3575
Checklist
changelog.d