Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire-server.nix: Add aws cli to all integration test docker images #3653

Merged
merged 1 commit into from
Oct 16, 2023
Merged

wire-server.nix: Add aws cli to all integration test docker images #3653

merged 1 commit into from
Oct 16, 2023

Conversation

akshaymankar
Copy link
Member

@akshaymankar akshaymankar commented Oct 16, 2023 •
edited
Loading

Required for #3633
https://wearezeta.atlassian.net/browse/WPB-4267

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d No changelog.
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 16, 2023
MangoIV
MangoIV approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@MangoIV MangoIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akshaymankar akshaymankar merged commit a88d9b3 into develop Oct 16, 2023
@akshaymankar akshaymankar deleted the integration-aws-cli branch October 16, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MangoIV MangoIV MangoIV approved these changes

@smatting smatting Awaiting requested review from smatting

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshaymankar @MangoIV @zebot