Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fork of warp which closes connections gracefully #3775

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Use fork of warp which closes connections gracefully #3775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6ccfc8
Use fork of warp which closes connections gracefully
akshaymankar Dec 12, 2023
27c170d
changelog
akshaymankar Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog.d/3-bug-fixes/warp-connection-close
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Ensure that HTTP 1.1 connections are grafully closed

To fix this warp had to be patched to fix the bug upstream: https://github.com/yesodweb/wai/pull/958
15 changes: 11 additions & 4 deletions nix/haskell-pins.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,17 @@ let
sha256 = "sha256-xcGZ11ocdlB8ks20QAhtPZ+4ggmV4Om4CPHH/M6NjXk=";
};
};
# PR: https://github.com/yesodweb/wai/pull/958
warp = {
src = fetchgit {
url = "https://github.com/wireapp/wai";
rev = "bedd6a835f6d98128880465c30e8115fa986e3f6";
sha256 = "sha256-0r/d9YwcKZIZd10EhL2TP+W14Wjk0/S8Q4pVvZuZLaY=";
};
packages = {
"warp" = "warp";
};
};
};
hackagePins = {
# Major re-write upstream, we should get rid of this dependency rather than
Expand Down Expand Up @@ -292,10 +303,6 @@ let
version = "1.4.0";
sha256 = "sha256-zPT/FMxAiR94NReqNIDa/RS7dtiNWCRe3SZi8P11GDk=";
};
warp = {
version = "3.3.30";
sha256 = "sha256-VrK27a2wFtezh9qabcXGe2tw9EwBmI8mKwmpCtXq9rc=";
};
warp-tls = {
version = "3.4.3";
sha256 = "sha256-6MjlCKGC8v+7OiSuMFGwO8sgcA3gp0OfOnneI2wSpWI=";
Expand Down
Loading