Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ejpd data model exhaustive #3875

Merged
merged 9 commits into from
Mar 12, 2024
Merged

Conversation

fisx
Copy link
Contributor

@fisx fisx commented Feb 6, 2024

https://wearezeta.atlassian.net/browse/WPB-6329

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 6, 2024
@fisx fisx force-pushed the WPB-6329-make-EJPD-data-model-exhaustive branch from 44a8377 to 7232c16 Compare February 6, 2024 16:16
@fisx fisx force-pushed the WPB-6329-make-EJPD-data-model-exhaustive branch 4 times, most recently from 8b7344d to 85bb079 Compare February 21, 2024 12:51
@fisx fisx force-pushed the WPB-6329-make-EJPD-data-model-exhaustive branch 2 times, most recently from 610c61e to 8e751ff Compare February 27, 2024 11:29
@fisx fisx force-pushed the WPB-6329-make-EJPD-data-model-exhaustive branch 5 times, most recently from b3c5f18 to cf6a7dc Compare March 5, 2024 12:46
@fisx fisx marked this pull request as ready for review March 5, 2024 12:47
@fisx fisx force-pushed the WPB-6329-make-EJPD-data-model-exhaustive branch 2 times, most recently from 431a46f to 354e5b7 Compare March 11, 2024 10:18
@fisx fisx force-pushed the WPB-6329-make-EJPD-data-model-exhaustive branch from 354e5b7 to eca4fb5 Compare March 12, 2024 09:04
@fisx fisx requested a review from battermann March 12, 2024 10:17
Comment on lines +24 to +37
EJPDResponseItem
( EJPDResponseItem,
ejpdResponseUserId,
ejpdResponseTeamId,
ejpdResponseName,
ejpdResponseHandle,
ejpdResponseEmail,
ejpdResponsePhone,
ejpdResponsePushTokens,
ejpdResponseContacts,
ejpdResponseTeamContacts,
ejpdResponseConversations,
ejpdResponseAssets
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
EJPDResponseItem
( EJPDResponseItem,
ejpdResponseUserId,
ejpdResponseTeamId,
ejpdResponseName,
ejpdResponseHandle,
ejpdResponseEmail,
ejpdResponsePhone,
ejpdResponsePushTokens,
ejpdResponseContacts,
ejpdResponseTeamContacts,
ejpdResponseConversations,
ejpdResponseAssets
),
EJPDResponseItem (..)

not very important, though

@fisx fisx merged commit 709ee55 into develop Mar 12, 2024
8 checks passed
@fisx fisx deleted the WPB-6329-make-EJPD-data-model-exhaustive branch March 12, 2024 12:40
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants