Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix openapi docs of UTCTime and UTCTimeMillis #3899

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Fix openapi docs of UTCTime and UTCTimeMillis #3899

merged 3 commits into from
Mar 18, 2024

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Feb 26, 2024 •
edited
Loading

Fix openapi docs inconsistency with datetime fields. We have two kinds of datetime fields: with and without a millisecond component. They were both documented as having the millisecond component.

https://wearezeta.atlassian.net/browse/WPB-6529

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines
  • Add note to "API changes" page

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Feb 26, 2024
@pcapriotti pcapriotti force-pushed the pcapriotti/last-active-timestamp branch from a8dc9f5 to 8484a6c Compare March 11, 2024 09:20
@pcapriotti pcapriotti marked this pull request as ready for review March 15, 2024 08:32
supersven
supersven approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@supersven supersven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM 👍

@pcapriotti pcapriotti force-pushed the pcapriotti/last-active-timestamp branch from 0b57d1a to 84fceed Compare March 15, 2024 09:18
@pcapriotti pcapriotti merged commit 022aa39 into develop Mar 18, 2024
8 checks passed
@pcapriotti pcapriotti deleted the pcapriotti/last-active-timestamp branch March 18, 2024 08:02
@zebot zebot mentioned this pull request Apr 25, 2024
Merged
@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanwire stefanwire stefanwire approved these changes

@supersven supersven supersven approved these changes

Assignees
No one assigned
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pcapriotti @supersven @stefanwire @zebot